← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/cleanup-plugins into lp:openlp

 

Review: Needs Fixing

Missed one (or two):

3460	+ self.portLabel = QtGui.QLabel(self.server_settings_group_box)
3584	+ ipAddress = self.address_edit.text()

Is there a reason these haven't been refactored?

- serviceItem
- self.serviceItem
- self.currentMediaPlayer
- self.displayControllers

-- 
https://code.launchpad.net/~trb143/openlp/cleanup-plugins/+merge/151803
Your team OpenLP Core is subscribed to branch lp:openlp.


References