← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/short-lines into lp:openlp

To: mp+152219@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Thu, 07 Mar 2013 17:24:20 -0000
In-reply-to: <20130307164240.26271.59230.launchpad@ackee.canonical.com>
Reply-to: mp+152219@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

2569 self.progressPage.setObjectName(u'progress_page')
you cannot change the object name and not the object name!

NO MORE SCOPE SCOPE THIS IS TOO BIG.

I could also say you should wait on Raoul as he was waiting on me to do my merges.
-- 
https://code.launchpad.net/~googol/openlp/short-lines/+merge/152219
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol/openlp/short-lines into lp:openlp
From: Andreas Preikschat, 2013-03-07