← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~googol/openlp/transitions into lp:openlp

 

Andreas Preikschat has proposed merging lp:~googol/openlp/transitions into lp:openlp.

Requested reviews:
  OpenLP Core (openlp-core)

For more details, see:
https://code.launchpad.net/~googol/openlp/transitions/+merge/152852

Hello,

I/we figured out, that transitions which end/start at a opacity of 0.2 do not look fluent. When set to 0.1 the transition look smoother. 
-- 
https://code.launchpad.net/~googol/openlp/transitions/+merge/152852
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/transitions into lp:openlp.
=== modified file 'openlp/core/lib/htmlbuilder.py'
--- openlp/core/lib/htmlbuilder.py	2013-03-07 12:59:35 +0000
+++ openlp/core/lib/htmlbuilder.py	2013-03-12 09:08:22 +0000
@@ -164,8 +164,8 @@
             text.innerHTML = new_text;
             return;
         }
-        // Fade text out. 0.2 to minimize the time "nothing" is shown on the screen.
-        text.style.opacity = '0.2';
+        // Fade text out. 0.1 to minimize the time "nothing" is shown on the screen.
+        text.style.opacity = '0.1';
         // Fade new text in after the old text has finished fading out.
         timer = window.setTimeout(function(){_show_text(text, new_text)}, 400);
     }


Follow ups