openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

The proposal to merge lp:~googol/openlp/service-manager into lp:openlp has been updated.

Description changed to:

Hello,

- break loop, when service item has been found to be not valid

EDIT: The complete method looks like this:

    def validate_item(self, suffix_list=None):
        """
        Validates a service item to make sure it is valid
        """
        self.is_valid = True
        for frame in self._raw_frames:
            if self.is_image() and not os.path.exists(frame[u'path']):
                self.is_valid = False
                break
            elif self.is_command():
                file_name = os.path.join(frame[u'path'], frame[u'title'])
                if not os.path.exists(file_name):
                    self.is_valid = False
                    break
                if suffix_list and not self.is_text():
                    file_suffix = frame[u'title'].split(u'.')[-1]
                    if file_suffix.lower() not in suffix_list:
                        self.is_valid = False
                        break

For more details, see:
https://code.launchpad.net/~googol/openlp/service-manager/+merge/153136
-- 
https://code.launchpad.net/~googol/openlp/service-manager/+merge/153136
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/service-manager into lp:openlp.