openlp-core team mailing list archive
-
openlp-core team
-
Mailing list archive
-
Message #19987
Re: [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp
Review: Needs Fixing
Minor comments
- __checkObject how can this be a utility method and get used once.
The cursor is set busy too early on context menu actions. Set it to busy after you have asked questions via the dialogs.
As you have added a new method to plugin_manager can you test it in the tests. The coverage is goods there will be some examples.
--
https://code.launchpad.net/~arjan-i/openlp/images_groups/+merge/153335
Your team OpenLP Core is subscribed to branch lp:openlp.
References