openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp

To: Arjan Schrijver <arjan@xxxxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sat, 16 Mar 2013 07:40:27 -0000
In-reply-to: <20130314114419.9413.52727.launchpad@ackee.canonical.com>
Reply-to: mp+153335@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Minor comments

- __checkObject  how can this be a utility method and get used once.

The cursor is set busy too early on context menu actions.  Set it to busy after you have asked questions via the dialogs.

As you have added a new method to plugin_manager can you test it in the tests.  The coverage is goods there will be some examples.
-- 
https://code.launchpad.net/~arjan-i/openlp/images_groups/+merge/153335
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~arjan-i/openlp/images_groups into lp:openlp
From: Arjan Schrijver, 2013-03-14