openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing

445	- u'audio_pause_item',
446	+ u'audioPauseItem',

Please add a comment why you are changing it back.


560	- if plugin.status == PluginStatus.Active and plugin.media_item and plugin.mediaItem.hasSearch:
561	+ if plugin.status == PluginStatus.Active and plugin.media_item and plugin.mediaItem.has_search:

Would you mind fixing this regression? mediaItem does not exist anymore. There are two occurrences (lines 569/570).
-- 
https://code.launchpad.net/~trb143/openlp/cleanup/+merge/155092
Your team OpenLP Core is subscribed to branch lp:openlp.