openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing

152	+ match = re.match(u'(\D*)(\d+)', verse_name)

For regular expression you use r'' instead of u''


20	- self.verseOrderListGenerated.append(verse_def)
21	+ if verse_def not in self.verseOrderListGenerated:
22	+     self.verseOrderListGenerated.append(verse_def)

Why are you changing this? Docs say:
        Add a verse. This is the whole verse, lines split by \\n. It will also
        attempt to detect duplicates. In this case it will just add to the verse
        order.
So we should append the verse_def in any case, shouldn't we?
-- 
https://code.launchpad.net/~phill-ridout/openlp/bug1125956/+merge/156075
Your team OpenLP Core is subscribed to branch lp:openlp.