← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~m2j/openlp/bug-1094342 into lp:openlp

 

The proposal to merge lp:~m2j/openlp/bug-1094342 into lp:openlp has been updated.

Description changed to:

This branch replaces the "cmp=" argument when sorting a list of strings. This is necessary for Python3 transition.

Additionally it uses ICU for locale aware string sorting. For Windows this is mandatory as Microsoft provides a broken locale.strcoll method. For Python 2 we can't use Pythons locale aware sorting, as a bug breaks the key generation for unicode.

I replaced the natural compare algorithm in openlp/plugins/songs/lib/__init__.py and placed it in openlp/core/utils/__init__.py as there might be wider use. Additional I precompute the full sorting key for song sorting. This should improve the song sorting performance significantly.

For more details, see:
https://code.launchpad.net/~m2j/openlp/bug-1094342/+merge/156284
-- 
https://code.launchpad.net/~m2j/openlp/bug-1094342/+merge/156284
Your team OpenLP Core is subscribed to branch lp:openlp.


References