← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~marmyshev/openlp/item_title into lp:openlp

 

38-40 - New Campability (like CanEditTitle) will need to add almost in every plugin. This is not good if you already have campability about title...
code:

not service_item[u'service_item'].is_capable(ItemCapabilities.HasDetailedTitleDisplay) and not service_item[u'service_item'].is_capable(ItemCapabilities.CanEdit)

works better and easer to understand, then:

not (service_item[u'service_item'].is_capable(ItemCapabilities.HasDetailedTitleDisplay) or service_item[u'service_item'].is_capable(ItemCapabilities.CanEdit))

82-88 Please, go deeper in the idea. This is new behavior when you add images and this extends scenarios of using: You can edit title of one image, edit title for several images, edit title for added group of images, and replace and update title if you didnt edit the title in the service for all previous scenarios. 8-9 needed for support this future.

56-62 - need to remove.
-- 
https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/156694
Your team OpenLP Core is subscribed to branch lp:openlp.


References