openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Disagree about the Capabilities.  They say what you can do and are data agnostic.
A new one of CanEditTitle would be fine for Images and Bibles.  None of the others would need this and so what about having to add to other plugins.  

75 - 82 become service_item.title = None only (you seem to be missing an else but it may be my reading of the merge.

8 -9 becomes something like this.

if text() or (CanEditTitle and title)
   return title.
if CanEditTitle and not title
   if _raw > 1:
      return unicode(Registry().get(self.plugin.name).name_strings[u'plural'])
   else
      return unicode(Registry().get(self.plugin.name).name_strings[u'singular'])
-- 
https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/157510
Your team OpenLP Core is subscribed to branch lp:openlp.