← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~marmyshev/openlp/item_title into lp:openlp

To: Dmitriy Marmyshev <marmyshev@xxxxxxxxx>
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sat, 13 Apr 2013 13:03:24 -0000
In-reply-to: <20130412153823.5860.71331.launchpad@ackee.canonical.com>
Reply-to: mp+158653@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Much better but Have issue with 104-110 please see previous comment.
You are exposing the internals of a ServiceItem to a plugin and that should be bad practice.

The rest looks good to me though.
-- 
https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/158653
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~marmyshev/openlp/item_title into lp:openlp
From: Dmitriy Marmyshev, 2013-04-12