← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~trb143/openlp/cherrypy into lp:openlp

To: mp+157697@xxxxxxxxxxxxxxxxxx
From: Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>
Date: Sun, 14 Apr 2013 15:42:25 -0000
In-reply-to: <20130408165718.13449.40898.launchpad@ackee.canonical.com>
Reply-to: mp+157697@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Incomplete docs: line 18, 31, 566, 1656, 1670 (Once I decided, that I don't want to approve any proposals with incomplete doc strings.)

362	+ Create an encrypted password for the given password.
hashing

Why old-style classes? (line 482, 494, 503)?


-- 
https://code.launchpad.net/~trb143/openlp/cherrypy/+merge/157697
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~trb143/openlp/cherrypy into lp:openlp
From: Tim Bentley, 2013-04-08