← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~arjan-i/openlp/images_groups_bugfix into lp:openlp

 

Have you tried running my branch? It doesn't add the item twice, but it does the following:
- When you add a group, it adds one service item with all images from that group.
- When you add a list of images, it adds one service item with all images in it.
- When you add a list of groups, it adds a service item for each group.

Of course I can change back the code to only allow adding one service item at a time, but I think the current functionality (in my branch) is better and more logical.

The behavior above is what I have already achieved :) The question is whether the way I did it is acceptable.
-- 
https://code.launchpad.net/~arjan-i/openlp/images_groups_bugfix/+merge/156165
Your team OpenLP Core is subscribed to branch lp:openlp.


References