← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~phill-ridout/openlp/worshipcenterpro_import into lp:openlp

To: mp+158819@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sun, 14 Apr 2013 20:27:24 -0000
In-reply-to: <20130414201727.1971.75333.launchpad@ackee.canonical.com>
Reply-to: mp+158819@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

importer.logError = mocked_log_error Could be importer.logError = MagicMock() etc

334 - 335 feels like something is missing like a test! 
Count of how many adds there were or ........
-- 
https://code.launchpad.net/~phill-ridout/openlp/worshipcenterpro_import/+merge/158819
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~phill-ridout/openlp/worshipcenterpro_import into lp:openlp
From: Phill, 2013-04-14