openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~petersbentley/openlp/fixes into lp:openlp

To: PSB143 <petesbentley@xxxxxxxxx>
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Thu, 23 May 2013 20:25:54 -0000
In-reply-to: <20130523163226.7959.40763.launchpad@ackee.canonical.com>
Reply-to: mp+165436@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Hi Peter,

Welcome to OpenLP! I trust you'll be able to find your feet in development, as well as the greater online open source community.

Your merge proposal message is vague and unspecific. Please see the page on the wiki on branching and merge proposals, it has guidelines on how to write a good description: http://wiki.openlp.org/Development:Branching_And_Merging_Standards

Please also make your commit message a little more specific.

Otherwise, this looks good as a first submission, well done!
-- 
https://code.launchpad.net/~petersbentley/openlp/fixes/+merge/165436
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~petersbentley/openlp/fixes into lp:openlp
From: PSB143, 2013-05-23