openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Welcome on board but I do not believe the fix is as simple as your change.
I did try this before and had issues!.

I have save two songs and 2 media in a lite file and the reloaded it.
Traceback (most recent call last):
  File "/home/tim/Projects/openlp/json-service-format/openlp/core/ui/servicemanager.py", line 431, in on_recent_service_clicked
    self.load_file(sender.data())
  File "/home/tim/Projects/openlp/json-service-format/openlp/core/ui/servicemanager.py", line 707, in load_file
    items = json.load(file_to)
  File "/usr/lib64/python2.7/json/__init__.py", line 290, in load
    **kw)
  File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python2.7/json/decoder.py", line 365, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python2.7/json/decoder.py", line 383, in raw_decode
    raise ValueError("No JSON object could be decoded")
ValueError: No JSON object could be decoded


I have in the pas had errors saving as well.

The tests will need to be updated and a test pack delivered to prove an existing service can be loaded and saved back to a json without any issues.

As a minor point can we have "osj" instead of "osjd".
-- 
https://code.launchpad.net/~tomasgroth/openlp/json-service-format/+merge/168283
Your team OpenLP Core is subscribed to branch lp:openlp.