openlp-core team mailing list archive

[mohij <patrick@xxxxxxxxx>]

Hey, thank you for the quick reply!

> Cancel does not work!

Can you clarify? I tried the cancel button an all wizard pages and it always instantly exits the wizard here. What's happening for you? What do you expect?
 
> why do I get "Praise Him You Heavens  =   a"?   a is a blank test song and it
> seems to get matched in the output with many of my songs!

Hm.This is a problem with the algorithm I use. I am not entirely sure this is wrong. The idea behind this is: "100% of the empty song is contained in the other one, so it's probably a shorter version of the same song (e.g. missing some verses)." From that perspective, do you think I should do something about it?

> Display is difficult to work with 3 matches!

Did you try resizing the window (fullscreen)? If that solves the problem, do you think I should add a note that the window is resizable? Should I try to dynamically resize the window (personally I think that's a bad idea - it causes a "jumping window effect", seems annoying)? Do you have any other idea what could be done about it?

> 297 extra blank line.

Removed.

> division - please check the python packages to make sure you have the correct
> maths.  http://bazaar.launchpad.net/~openlp-core/openlp/trunk/revision/2244

Replaced all divisions with the correct counterpart.

> Should the song delete code be common with the main code?

Seems like a good idea. Will have a look tomorrow.
-- 
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review-2/+merge/168594
Your team OpenLP Core is subscribed to branch lp:openlp.