openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

Review: Needs Fixing

41	- if not os.path.isfile(self.import_source):
42	-     return
43	- if not os.path.isfile(import_source_mb):
44	+ if not (os.path.isfile(self.import_source) or os.path.isfile(import_source_mb))

Should be:
   if not os.path.isfile(self.import_source) or not os.path.isfile(import_source_mb):


I know you probably did not wrote the code, but could you add an enumeration class for the numbers?

   if field_desc.type == 1:
should be
   if field_desc.type == MyEnumerationClass.FirstEnumeration
-- 
https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/171737
Your team OpenLP Core is subscribed to branch lp:openlp.