openlp-core team mailing list archive

[Andreas Preikschat <andreaspreikschat@xxxxxxxxxx>]

The proposal to merge lp:~googol/openlp/print-func into lp:openlp has been updated.

Description changed to:

- Converted last print statements to print functions.
- Removed old test

I removed the test, because the test did not work:

[andreas@andylaptop trunk]$ python2 openlp/plugins/songs/lib/test/test_opensongimport.py
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/test/test_opensongimport.py", line 30, in <module>
    from openlp.plugins.songs.lib.opensongimport import OpenSongImport
  File "/home/andreas/Projects/OpenLP/trunk/openlp/plugins/songs/lib/__init__.py", line 147, in <module>
    class VerseType(object):
  File "/home/andreas/Projects/OpenLP/trunk/openlp/plugins/songs/lib/__init__.py", line 178, in VerseType
    translated_tags = [name[0].lower() for name in translated_names]
AttributeError: 'QString' object has no attribute 'lower'

I added the sip code and the next traceback was this. So I thought I should remove it (nobody noticed until now, nobody will miss this code).

Traceback (most recent call last):
  File "openlp/plugins/songs/lib/test/test_opensongimport.py", line 140, in <module>
    test()
  File "openlp/plugins/songs/lib/test/test_opensongimport.py", line 60, in test
    manager = Manager(u'songs', init_schema)
  File "/home/andreas/Projects/OpenLP/print-func/openlp/core/lib/db.py", line 188, in __init__
    db_type = settings.value(u'db type')
  File "/home/andreas/Projects/OpenLP/print-func/openlp/core/lib/settings.py", line 429, in value
    default_value = Settings.__default_settings__[self.group() + u'/' + key]
KeyError: u'songs/db type'

For more details, see:
https://code.launchpad.net/~googol/openlp/print-func/+merge/172245
-- 
https://code.launchpad.net/~googol/openlp/print-func/+merge/172245
Your team OpenLP Core is requested to review the proposed merge of lp:~googol/openlp/print-func into lp:openlp.