← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~tomasgroth/openlp/json-service-format into lp:openlp

 

Review: Needs Fixing

One last thing: Please just merge trunk into your branch. One of the tests is currently failing, and I know that Tim fixed it up in trunk.

======================================================================
FAIL: Test the Service Item - migrating a media only service item from 2.0 to 2.2 format
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/raoul/Projects/OpenLP/json-service-format/tests/functional/openlp_core_lib/test_serviceitem.py", line 285, in serviceitem_migrate_test_20_22
    assert service_item.processor is None, u'The Processor should have been set'
AssertionError: The Processor should have been set
-------------------- >> begin captured logging << --------------------
openlp.core.lib.registry: INFO: Registry Initialising
openlp.core.lib.serviceitem: DEBUG: set_from_service called with path /home/raoul/Projects/OpenLP/json-service-format/tests/resources
--------------------- >> end captured logging << ---------------------

-- 
https://code.launchpad.net/~tomasgroth/openlp/json-service-format/+merge/173244
Your team OpenLP Core is subscribed to branch lp:openlp.


References