openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

On lines 73 and 74 below, where does "self.tr()" come from? We don't use it anywhere else.

Also on lines 73 and 74, please take note of the String Standards on the wiki: http://wiki.openlp.org/Development:String_Standards

The title of the dialog should be in title case. Additionally, it should be something more informative, like, "Rename Item"

The label in the dialog should also be something more informative than "Title", for instance, "Rename the select item to:"
-- 
https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/173606
Your team OpenLP Core is subscribed to branch lp:openlp.