← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~openlp-core/openlp/python3-productive into lp:openlp

 

The proposal to merge lp:~openlp-core/openlp/python3-productive into lp:openlp has been updated.

Description changed to:

Hello,

I thought you should start to review the python 3 changes.

Procedure:
1) We merge the changes below in a proposal.
2) After merging I will propose again with only changes made by 2to3.

To review this run:
    2to3 --write --nobackups --no-diffs -x next print *
    sh scripts/generate_resources.sh

- changes required to run openlp with python3
- python3 does not have a buffer type, however, it is said that the "the memoryview API is similar but not exactly the same as that of buffer" [1], that is why I removed the check (we do not know if we get a memoryview object)
- ICU is now not required on linux and mac

[1] http://docs.python.org/2/library/2to3.html#fixers

For more details, see:
https://code.launchpad.net/~openlp-core/openlp/python3-productive/+merge/175454
-- 
https://code.launchpad.net/~openlp-core/openlp/python3-productive/+merge/175454
Your team OpenLP Core is requested to review the proposed merge of lp:~openlp-core/openlp/python3-productive into lp:openlp.


References