openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

> Why do you check the charset each time?
> 
> Line 14 changed to
>   data = unicode( song_data.read(length_descriptor),
> chardet.detect(data)['encoding'] )
> should be enough

This would not work, because the length descriptor has no encoding. It is a byte of which the binary value specifies the length in bytes of the following string. So I guess you could say it has no encoding!
-- 
https://code.launchpad.net/~phill-ridout/openlp/1194610/+merge/178456
Your team OpenLP Core is subscribed to branch lp:openlp.