openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Review: Needs Fixing

Neither "valid_xml_char_ordinal()" nor "clean_xml_string()" need to be static methods on that class. Just make them regular functions in the module.

Also, I see no reason why they need to be separated. In fact, the contents of "valid_xml_char_ordinal()" should be a CONSTANT in the module.
-- 
https://code.launchpad.net/~phill-ridout/openlp/1213254_2.0/+merge/180683
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.