← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #21517

Re: [Merge] lp:~mahfiaz/openlp/opensong-bible-importer-crash into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Needs Fixing

Lines 34 and 41 are not needed.

You need to add a test even if it is not connected to the change.  Welcome to the 2.2 world!
-- 
https://code.launchpad.net/~mahfiaz/openlp/opensong-bible-importer-crash/+merge/181968
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next