← Back to team overview

openlp-core team mailing list archive

[Merge] lp:~raoul-snyman/openlp/bug-1216785-2.0 into lp:openlp/2.0

 

Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1216785-2.0 into lp:openlp/2.0.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1216785 in OpenLP: "Adding notes to service causes error on save"
  https://bugs.launchpad.net/openlp/+bug/1216785

For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1216785-2.0/+merge/182193

Fix bug #1216785 by casting to unicode before adding to the service.
-- 
https://code.launchpad.net/~raoul-snyman/openlp/bug-1216785-2.0/+merge/182193
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/bug-1216785-2.0 into lp:openlp/2.0.
=== modified file 'openlp/core/ui/servicemanager.py'
--- openlp/core/ui/servicemanager.py	2013-06-30 12:14:30 +0000
+++ openlp/core/ui/servicemanager.py	2013-08-26 19:28:22 +0000
@@ -796,7 +796,7 @@
             self.serviceItems[item][u'service_item'].notes)
         if self.serviceNoteForm.exec_():
             self.serviceItems[item][u'service_item'].notes = \
-                self.serviceNoteForm.textEdit.toPlainText()
+                unicode(self.serviceNoteForm.textEdit.toPlainText())
             self.repaintServiceList(item, -1)
             self.setModified()
 

=== modified file 'openlp/core/ui/servicenoteform.py'
--- openlp/core/ui/servicenoteform.py	2012-12-30 19:41:24 +0000
+++ openlp/core/ui/servicenoteform.py	2013-08-26 19:28:22 +0000
@@ -32,6 +32,7 @@
 from openlp.core.lib import translate, SpellTextEdit
 from openlp.core.lib.ui import create_button_box
 
+
 class ServiceNoteForm(QtGui.QDialog):
     """
     This is the form that is used to edit the verses of the song.


Follow ups