← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~marmyshev/openlp/item_title into lp:openlp

 

Review: Needs Fixing

56	+ if service_item[u'service_item'].is_capable(ItemCapabilities.CanEditTitle):
70	+ if not self.service_items[item][u'service_item'].is_capable(ItemCapabilities.CanEditTitle):
72	+ title = self.service_items[item][u'service_item'].title
76	+ self.service_items[item][u'service_item'].title = unicode(title)

This is Python 3, no more u's in front of Unicode strings. Did you actually try to run this code?
-- 
https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/183812
Your team OpenLP Core is subscribed to branch lp:openlp.


References