openlp-core team mailing list archive

[Jeffrey Smith <whydoubt@xxxxxxxxx>]

Review: Needs Fixing

Whitespace issues:
  There should only be one space after a comma (about 30 cases)
     No: "        for (item,  expected) in zip(items,  expected_data):"
    Yes: "        for (item, expected) in zip(items, expected_data):"

  There should not be any spaces around the = when passing a keyword argument (5 cases)
     No: "        second_verse.data = MagicMock(return_value= 'V2')"
    Yes: "        second_verse.data = MagicMock(return_value='V2')"

  There should not be any spaces at the end of a non-blank line (3 cases)
     No: "        # Check if all verse tags are used.        "
    Yes: "        # Check if all verse tags are used."

  There should not be any spaces in a blank line (many cases)
  I'm assuming you're using an editor that auto-indents, but doesn't clean up
  after itself if you just want a blank line.  You may want to make your editor
  stop that, or find a better editor.
-- 
https://code.launchpad.net/~stewart-e/openlp/verse_order_override/+merge/184651
Your team OpenLP Core is requested to review the proposed merge of lp:~stewart-e/openlp/verse_order_override into lp:openlp.