← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/ft into lp:openlp

 

Code comments:

- Doc string o fsave_html_tags()

Bug:
1) Remove all tags
2) Save
3) Add a tag and save
4) Add another tag. And click save.
Result: A pop up saying that the last tag is already defined.

Rest:
1) I do not know how deep you looked at the code (vs just the GUI). What is with this html_expands list?
2) The GUI looks better. I asked myself: Why/How should the standard tags be shown? Or should they be visible at all?
3) Could we have a "in-line" validator (instead of the popup)? Make the line read when not valid? (But still allowig something like this:
start tag: <img src="
end tag: "></img>
?)
-- 
https://code.launchpad.net/~trb143/openlp/ft/+merge/184486
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/ft into lp:openlp.


References