openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Before going on with this change please can you email the core mailing list what the change is about and how you propose to fix it.
The change seems to be adding spaghetti code into code for songs and this is not part of the architecture.
Moving data around the system can only be done by a service item and not text strings.
There is already a way to make temporary changes to songs by cloning them why is that not acceptable / extendable.

It's good to see new ideas and improvements coming to OpenLP but we need to keep to code base maintainable.  
 
-- 
https://code.launchpad.net/~stewart-e/openlp/verse_order_override/+merge/184651
Your team OpenLP Core is subscribed to branch lp:openlp.