← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/html-clean-up into lp:openlp

To: mp+185079@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sun, 15 Sep 2013 06:08:50 -0000
In-reply-to: <20130911150923.20039.24766.launchpad@ackee.canonical.com>
Reply-to: mp+185079@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

If you are removing code from the Phonon player (copy paste error which I am not sure about) remove the frame work.  It was there to allow players have have their own CSS / Javascript so was there for a reason (at the time).

Rest looks OK 
-- 
https://code.launchpad.net/~googol/openlp/html-clean-up/+merge/185079
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~googol/openlp/html-clean-up into lp:openlp
From: Andreas Preikschat, 2013-09-11