openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~whydoubt/openlp/fix_platform_tests into lp:openlp

To: mp+185616@xxxxxxxxxxxxxxxxxx
From: Jeffrey Smith <whydoubt@xxxxxxxxx>
Date: Sun, 15 Sep 2013 20:21:47 -0000
In-reply-to: <20130915061249.19236.54179.codereview@soybean.canonical.com>
Reply-to: mp+185616@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> Dont just delete it will have use for a few.

I wouldn't say that I 'deleted' get_locale_key_windows_test/get_locale_key_linux_test so much as I took two halves and made one whole.  Running the Windows test on non-Windows made no sense, and running the non-Windows test on Windows made no sense.  And when you factor out the mock of os.name, it turns out they are the same test!
-- 
https://code.launchpad.net/~whydoubt/openlp/fix_platform_tests/+merge/185616
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~whydoubt/openlp/fix_platform_tests into lp:openlp
From: Tim Bentley, 2013-09-15