← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~phill-ridout/openlp/1012110_2.0 into lp:openlp/2.0

 

Review: Needs Fixing

I can't test this (as I don't have Windows), but there are a few things you need to change:

On line 17 you should use os.path.normpath(), don't do a manual find and replace. See http://docs.python.org/2/library/os.path.html#os.path.normpath

On line 22 you should use os.path.join().
-- 
https://code.launchpad.net/~phill-ridout/openlp/1012110_2.0/+merge/189408
Your team OpenLP Core is subscribed to branch lp:openlp/2.0.


References