← Back to team overview

openlp-core team mailing list archive

  1. openlp-core team
  2. Mailing list archive
  3. Message #22034

Re: [Merge] lp:~phill-ridout/openlp/song_helper into lp:openlp

  Thread Previous • Date Previous • • Thread Next 
Review: Approve

if your get_data method is only ever called by that class, I recommend making it private by adding a single underscore in front.
-- 
https://code.launchpad.net/~phill-ridout/openlp/song_helper/+merge/190486
Your team OpenLP Core is subscribed to branch lp:openlp.

References

  Thread Previous • Date Previous • • Thread Next