openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

You need GIVEN, WHEN and THEN comments, your assert should have a message, and you shouldn't be creating the object in the setUp if you're testing that.


class TestPresentationController(TestCase):
    """
    Test the mediaitem methods.
    """
    def constructor_test(self):
        """
        Set up the components need for all tests.
        """
        # GIVEN: No presentation controller
        controller = None

        # WHEN: The presentation controller object is created
        controller = PresentationController(plugin=MagicMock())

        # THEN: The name of the presentation controller should be correct
        self.assertEqual('PresentationController', controller.name,
                         'The name of the presentation controller should be correct')

-- 
https://code.launchpad.net/~sam92/openlp/fix-presentation-loading/+merge/192180
Your team OpenLP Core is subscribed to branch lp:openlp.