← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/refactor into lp:openlp

 

Review: Needs Fixing

66	+ except Exception as e:
67	+ if log.getEffectiveLevel() <= logging.ERROR:
68	+ log.error('Exception in %s : %s' % (func.__name__, e))

This is going to catch all exceptions, and will cause problems when we need exceptions to bubble up. Reraise the exception.
-- 
https://code.launchpad.net/~trb143/openlp/refactor/+merge/192825
Your team OpenLP Core is subscribed to branch lp:openlp.


References