← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~felipe-q/openlp/fix_httprouter into lp:openlp

To: Felipe Polo-Wood <felipe@xxxxxxxxxxxxx>
From: Raoul Snyman <raoul@xxxxxxxxxxx>
Date: Thu, 14 Nov 2013 18:29:48 -0000
In-reply-to: <20131111143059.19784.77713.launchpad@ackee.canonical.com>
Reply-to: mp+194693@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

> 2. I disagree, this is the unit test for this method, and this method will be called with
> OS specific paths and I think it should be tested for them. Please comment.

If it's operating system specific or dependent, you're doing it wrong. Please fix.
-- 
https://code.launchpad.net/~felipe-q/openlp/fix_httprouter/+merge/194693
Your team OpenLP Core is subscribed to branch lp:openlp.

References

[Merge] lp:~felipe-q/openlp/fix_httprouter into lp:openlp
From: Felipe Polo-Wood, 2013-11-11