openlp-core team mailing list archive

[Phill <phill.ridout@xxxxxxxxx>]

Phill has proposed merging lp:~phill-ridout/openlp/bug1252477_2.0 into lp:openlp/2.0.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1252477 in OpenLP: "Changing theme on bible settings tab causes an error when saving service"
  https://bugs.launchpad.net/openlp/+bug/1252477

For more details, see:
https://code.launchpad.net/~phill-ridout/openlp/bug1252477_2.0/+merge/196005

Fix for #1252477
-- 
https://code.launchpad.net/~phill-ridout/openlp/bug1252477_2.0/+merge/196005
Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/bug1252477_2.0 into lp:openlp/2.0.

=== modified file 'openlp/plugins/bibles/lib/biblestab.py'
--- openlp/plugins/bibles/lib/biblestab.py	2012-12-30 19:41:24 +0000
+++ openlp/plugins/bibles/lib/biblestab.py	2013-11-20 19:36:49 +0000
@@ -293,7 +293,7 @@
             translate('BiblesPlugin.BiblesTab', 'English'))
 
     def onBibleThemeComboBoxChanged(self):
-        self.bible_theme = self.bibleThemeComboBox.currentText()
+        self.bible_theme = unicode(self.bibleThemeComboBox.currentText())
 
     def onDisplayStyleComboBoxChanged(self):
         self.display_style = self.displayStyleComboBox.currentIndex()