openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1259606-2.0 into lp:openlp/2.0.

Requested reviews:
  OpenLP Core (openlp-core)
Related bugs:
  Bug #1259606 in OpenLP: "Clicking Verse Button doesn't alter live slide"
  https://bugs.launchpad.net/openlp/+bug/1259606

For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-1259606-2.0/+merge/199873

When a user clicks on the row headers (yes, in 4 years no one has done that), the row is selected but the slide doesn't change. This fixes that.
-- 
https://code.launchpad.net/~raoul-snyman/openlp/bug-1259606-2.0/+merge/199873
Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/bug-1259606-2.0 into lp:openlp/2.0.

=== modified file 'openlp/core/ui/slidecontroller.py'
--- openlp/core/ui/slidecontroller.py	2013-02-10 12:21:59 +0000
+++ openlp/core/ui/slidecontroller.py	2013-12-20 22:15:56 +0000
@@ -44,6 +44,7 @@
 
 log = logging.getLogger(__name__)
 
+
 class SlideList(QtGui.QTableWidget):
     """
     Customised version of QTableWidget which can respond to keyboard
@@ -390,7 +391,7 @@
                 self._slideShortcutActivated)
         # Signals
         QtCore.QObject.connect(self.previewListWidget,
-            QtCore.SIGNAL(u'clicked(QModelIndex)'), self.onSlideSelected)
+            QtCore.SIGNAL(u'itemSelectionChanged()'), self.onSlideSelected)
         if self.isLive:
             QtCore.QObject.connect(Receiver.get_receiver(),
                 QtCore.SIGNAL(u'slidecontroller_live_spin_delay'),