openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

General comments.
PEP 8 standards and lines of 120 need to be implemented.  The code is a mixture of standards and needs to be sorted out.

ImageManager needs to add width and height.  Dimensions is a gives no clues what it contains.

The thumbnails need to be added to the imagemanager when the page is being displayed as it uses a thread to process the images.  This is not the correct way.

Registry.get is coded wrong.  Look at slideController for how to get include the image_mamanger,
-- 
https://code.launchpad.net/~felipe-q/openlp/better-remote/+merge/200135
Your team OpenLP Core is subscribed to branch lp:openlp.