openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

Conflicts with head.

lines 8-13 why.  This needs a good explanation as it looks like a botch.
lines 52-53 - fix for PEP8  -  have a look at other places as well.
line 77 - why not service?

Linn 200+  Confused.  If generated from plugin we have a image service item. Good.  If started from Service Manager we need to convert. Why? How did it get to the service manager cos the plugin would have created an image service item not a presentation one.  Also not sure about exposing the innards of the serviceitem in this could.  could it be a new method on the service item?

tmpFile = tmp_file

484 - 498 Line lengths.
611, 668, 675 etc tabbing
650 space

-- 
https://code.launchpad.net/~tomasgroth/openlp/mupdf/+merge/200161
Your team OpenLP Core is subscribed to branch lp:openlp.