openlp-core team mailing list archive

[Felipe Polo-Wood <felipe@xxxxxxxxxxxxx>]

I give up, man.  I can't work like this.  You are allowed to merge code that won't even start without errors in Windows, I fixed it so it at least starts, and now I have to create tests for fixing your code?
I will be uploading the code that enables WebSocket according to RFC6455 and that would be my last contribution to this project.  It is all integrated and it works.  I hope the code is up to your standards and you can use it, if not, hopefully someone can bring it up to your liking, but I won't have the time or will.  It has been nice working with you all.
Bye now.

Felipe Polo-Wood
919.741.4213


----- Original Message -----
From: "Tim Bentley" <tim.bentley@xxxxxxxxx>
To: "Felipe Polo-Wood" <felipe@xxxxxxxxxxxxx>
Sent: Thursday, January 9, 2014 2:19:41 PM
Subject: Re: [Merge] lp:~felipe-q/openlp/refactoring_fixes into lp:openlp

Review: Needs Fixing

Not sure about the settings changes the rest look OK.
You are missing tests though
-- 
https://code.launchpad.net/~felipe-q/openlp/refactoring_fixes/+merge/200892
You are the owner of lp:~felipe-q/openlp/refactoring_fixes.

https://code.launchpad.net/~felipe-q/openlp/refactoring_fixes/+merge/200892
Your team OpenLP Core is subscribed to branch lp:openlp.