openlp-core team mailing list archive

[Felipe Polo-Wood <felipe@xxxxxxxxxxxxx>]

All,

You all are witnesses that I have been asked to write tests for my code and that I have complied; I have been asked to write tests for code that I didn't write, but touched, and I have complied; I have been asked to modify my code for aesthetic reasons, and I have complied (not too happy, but I have); I have been told that I coded things wrong, and I have complied (even though I mostly find that discussion silly).  This is different, and I just can't do.
In this case, Tim made substantial changes to the code, and got it merged WITHOUT tests of adequate code coverage... code that is broken in all platforms. I couldn't merge my code until I merged with his changes, but, after merging I noticed problems, so I went back to the trunk and the problems were there (which, BTW, I did not have the time to fully review, there might be many more problems, I only spent about two hours to fix it enough to boot properly for my code to work). So, since Tim's changes have already been merged, I uploaded a small set of changes that would allow me to continue working on my stuff.  To my surprise, the answer from Tim, is that it is my responsibility to write the tests that he failed to write when he merged his changes, and... I just don't have the time to do that.  I am sorry, but that is reality; as most of you, I don't have all the time in the world to devote to this. I love the project, I have convinced several churches to switch... I have included references to it in my "Technology in the Ministry" course... none of that changes... but, my time is what it is, I will have to respond for it, and I will spend it in what I think is a wise use of it; writing tests that somebody else refuses to write is not something I consider a good use of my time.
Peace,

Felipe Polo-Wood
919.741.4213

----- Original Message -----
From: "Phill" <phill.ridout@xxxxxxxxx>
To: "Felipe Polo-Wood" <felipe@xxxxxxxxxxxxx>
Sent: Friday, January 10, 2014 6:47:48 AM
Subject: Re: [Merge] lp:~felipe-q/openlp/refactoring_fixes into lp:openlp

Hi Felipep,

It  is  regrettable that trunk broke for windows with a recent merge, but the fact is that we don't have any/many Windows (or osx) developers to test each merge request. Hopefully issues like this in the future will be caught by an increased number of tests. Unfortunately as testing wasn't implemented during the 2.0 rewrite we have to put extra effort in now to increase our coverage.

I stand with you in my frustration with writing tests but, having seen some of the regressions that have been released to our users, understand the importance for automated testing.

Finally I would like to encourage you to preserve with OpenLP development. I really like the ideas you have expressed and especially the functionality that you have already implemented in remote plugin.
-- 
https://code.launchpad.net/~felipe-q/openlp/refactoring_fixes/+merge/200892
You are the owner of lp:~felipe-q/openlp/refactoring_fixes.

https://code.launchpad.net/~felipe-q/openlp/refactoring_fixes/+merge/200892
Your team OpenLP Core is subscribed to branch lp:openlp.