← Back to team overview

openlp-core team mailing list archive

Re: [Merge] lp:~trb143/openlp/PEP8 into lp:openlp

 

Sometimes, the method name is so long the arguments look a little silly. In these cases, instead of doing this:

  folder = QtGui.QFileDialog.getExistingDirectory(self, title,
                                                  Settings().value(self.plugin.settings_section +
                                                  '/' + setting_name),
                                                  QtGui.QFileDialog.ShowDirsOnly)

I do this:

  folder = QtGui.QFileDialog.getExistingDirectory(
      self, title, Settings().value(self.plugin.settings_section + '/' + setting_name),
      QtGui.QFileDialog.ShowDirsOnly)

-- 
https://code.launchpad.net/~trb143/openlp/PEP8/+merge/208960
Your team OpenLP Core is requested to review the proposed merge of lp:~trb143/openlp/PEP8 into lp:openlp.


References