openlp-core team mailing list archive

[Raoul Snyman <raoul@xxxxxxxxxxx>]

Wow, long diff...

Just check your PEP8 stuff, things like, "start / 1000" and "end / 1000" (spaces either side of the sign).

Also,

  @staticmethod
  def parse_optical_path(input):
      ...

Static methods should only exist for very specific purposes. A normal module-level function for something like this is perfectly fine.
-- 
https://code.launchpad.net/~tomasgroth/openlp/dvd/+merge/209347
Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/dvd into lp:openlp.