openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

The events are different.  Why move to emit() ?

self.main_window.application.process_events()  Why not use application directly.

HistoryComboBox  should be in common not lib.

2468 extra blank line

Why is this on the main menu not via the importers
-- 
https://code.launchpad.net/~raoul-snyman/openlp/songselect2/+merge/209792
Your team OpenLP Core is subscribed to branch lp:openlp.