openlp-core team mailing list archive

[Rafael Lerm <rafaellerm@xxxxxxxxx>]

In line 33, 'item' is a string (I did not alter this). As a string is an iterable, calling append would cause 'self.video_extensions_list' to be a list os characters, not a list of strings. E.g. it would be ['V','i','d','e','o',' ','f',...] instead of ["Video files ..."]

In line 46, an action was missing, the population of the 'self.on_new_file_masks' attribute. This caused the supported extension list to not only be empty, but non-existant, throwing an extension every time an item is to be added. This attr was being populated after a configuration change (rebuild_players). So, analysing what was done in the initialization (l. 46) and what was done in rebuild_players, I decided to call rebuild_players directly (compare the change). The change in line 51 is because I changed the docstring to reflect this additional usage.

I did not understand what you mean with "new functionality", as this adds none (just fixes bugs).
-- 
https://code.launchpad.net/~rafaellerm/openlp/media_import_fix/+merge/210113
Your team OpenLP Core is subscribed to branch lp:openlp.