← Back to team overview

openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~googol/openlp/plugin-api into lp:openlp

To: mp+212295@xxxxxxxxxxxxxxxxxx
From: Tim Bentley <tim.bentley@xxxxxxxxx>
Date: Sun, 23 Mar 2014 07:52:35 -0000
In-reply-to: <20140322191619.6167.93690.codereview@chaenomeles.canonical.com>
Reply-to: mp+212295@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

Sorry but this is the wrong way to improve the code.  

Super Object methods have caused issues with tests due to the complexity of creating the class.  Here you are adding to the complexity not reducing it.

Also no tests.
-- 
https://code.launchpad.net/~googol/openlp/plugin-api/+merge/212295
Your team OpenLP Core is subscribed to branch lp:openlp.

References

Re: [Merge] lp:~googol/openlp/plugin-api into lp:openlp
From: Andreas Preikschat, 2014-03-22