openlp-core team mailing list archive

Thread
Date

Re: [Merge] lp:~tomasgroth/openlp/windows-fixes into lp:openlp

To: mp+212480@xxxxxxxxxxxxxxxxxx
From: Tomas Groth <tomasgroth@xxxxxxxx>
Date: Mon, 24 Mar 2014 20:23:32 -0000
In-reply-to: <20140324165325.12220.83976.launchpad@ackee.canonical.com>
Reply-to: mp+212480@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I don't see much harm in putting it in self.destroy_settings(), at most a small performance loss, but probably barely noticeable. But I'm not sure how many places it is actually needed, this is the only place I've seen this problem
The only problem I see is that not all test classes uses build/destroy_settings.
-- 
https://code.launchpad.net/~tomasgroth/openlp/windows-fixes/+merge/212480
Your team OpenLP Core is requested to review the proposed merge of lp:~tomasgroth/openlp/windows-fixes into lp:openlp.

References

[Merge] lp:~tomasgroth/openlp/windows-fixes into lp:openlp
From: Tomas Groth, 2014-03-24