openlp-core team mailing list archive

[Tim Bentley <tim.bentley@xxxxxxxxx>]

Review: Needs Fixing

[17:06][tim@tigger2] author-types $python3-pep8 openlp
openlp/plugins/songs/lib/db.py:51:28: E228 missing whitespace around modulo operator
openlp/plugins/songs/lib/db.py:54:1: E302 expected 2 blank lines, found 1
openlp/plugins/songs/lib/db.py:63:1: E302 expected 2 blank lines, found 1
openlp/plugins/songs/lib/db.py:77:1: E302 expected 2 blank lines, found 1
openlp/plugins/songs/lib/db.py:84:1: E302 expected 2 blank lines, found 1
openlp/plugins/songs/lib/mediaitem.py:238:21: E127 continuation line over-indented for visual indent
openlp/plugins/songs/lib/mediaitem.py:238:30: E228 missing whitespace around modulo operator
openlp/plugins/songs/lib/mediaitem.py:492:44: E228 missing whitespace around modulo operator
openlp/plugins/songs/lib/mediaitem.py:494:44: E228 missing whitespace around modulo operator
openlp/plugins/songs/lib/mediaitem.py:496:44: E228 missing whitespace around modulo operator
openlp/plugins/songs/lib/mediaitem.py:498:44: E228 missing whitespace around modulo operator
openlp/plugins/songs/lib/mediaitem.py:498:121: E501 line too long (131 > 120 characters)
openlp/plugins/songs/lib/mediaitem.py:499:28: E261 at least two spaces before inline comment
openlp/plugins/songs/lib/mediaitem.py:499:29: E262 inline comment should start with '# '
openlp/plugins/songs/lib/ui.py:43:63: E262 inline comment should start with '# '
openlp/plugins/songs/lib/upgrade.py:101:1: E302 expected 2 blank lines, found 1


168 why remove.  You can now haw songs without an author!

-- 
https://code.launchpad.net/~sam92/openlp/author-types/+merge/213389
Your team OpenLP Core is subscribed to branch lp:openlp.